-
Notifications
You must be signed in to change notification settings - Fork 231
Update release testing instructions to include DPM #21990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e49c9c6 to
f0efe8f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doing the dpm stuff tomorrow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've requested some changes, but they all involve wording or moving instructions around - since you want to merge by EOD I'm giving you approval - if there's still time in the day once you're done addressing comments, please ping me for a very quick second review.
34859c2 to
8284fb6
Compare
|
Will merge after Remy's feedback tomorrow |
DPM releases aren't weekly automated, so there is no consistent version string, or PR to comment on.
For these instructions, part of the work is to find/ensure a relevant DPM version exists.
Success notes will be on the Daml PR for now.
The weekly testing now covers multi-package functionality, by building a multi-package project, running the multi-ide, altering project structure and jumping across bounds.
DPM testing uses
dpm sandbox --dar ...overdaml sandbox, which requires building explicitly first. This is a small regression that we're aware of.Codegen commands are slightly different (
daml codegen javavsdpm codegen-java)