Skip to content

Improve DPM resolution missing error message #22613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
samuel-williams-da wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

Improve DPM resolution missing error message #22613

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/compiler/damlc/daml-resolution-config/src/DA/Daml/Resolution/Config.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ findPackageResolutionData path (ResolutionData packages) =
Map.lookup (toPosixFilePath path) packages & \case
Just (ErrorPackageResolutionData errs) -> Left $ ResolutionError $ "Couldn't resolve package " <> path <> ":\n" <> unlines (show <$> errs)
Just (ValidPackageResolutionData res) -> Right res
Nothing -> Left $ ResolutionError $ "Failed to find DPM package resolution for " <> path <> ". This should never happen, contact support."
Nothing -> Left $ ResolutionError $ "DPM did not provide information for package at " <> path <> ". Is this a valid package? If you have a multi-package.yaml, is this package included?"

resolutionFileEnvVar :: String
resolutionFileEnvVar = "DPM_RESOLUTION_FILE"
Expand Down