ghc-9.12.1-release #575
Merged
ghc-9.12.1-release #575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylant-da
approved these changes
Dec 19, 2024
Contributor
dylant-da
left a comment
dylant-da
left a comment
There was a problem hiding this comment.
Approved - mostly asking questions in order to learn.
| -- Last tested gitlab.haskell.org/ghc/ghc.git at | ||
| current :: String | ||
| current = "caaf53881d5cc82ebff617f39ad5363429d2eccf" -- 2024-11-25 | ||
| current = "bfacc086604c18e30758772a05a8c81e3a4e01bc" -- 2024-12-16 |
Contributor
There was a problem hiding this comment.
Is there a reason we use bfacc086604c18e30758772a05a8c81e3a4e01bc instead of https://gitlab.haskell.org/ghc/ghc/-/commit/daf659b6e3c8f2a84100fbee797cd9d457c00df5 from https://gitlab.haskell.org/ghc/ghc/-/tags/ghc-9.12.1-release ? Is it a question of what's furthest along on master?
Contributor
Author
There was a problem hiding this comment.
i tend to put here whatever the prevailing up to the minute SHA (https://gitlab.haskell.org/ghc/ghc/-/commits/master) is on the day that i prepare the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ghc-9.12.1 was released 2024-12-16. this PR adds official support for flavor ghc-9.12.1 (with a new test) and ghc-9.12.1 as a build compiler.
there's a temporary bit of cpp added to CI.hs and Ghclibgen.hs to support build/test with ghc-9.12.1 as a build compiler and the ormolu checks of those files is suspended.