Skip to content

Conversation

@shayne-fletcher
Copy link
Contributor

@shayne-fletcher shayne-fletcher commented May 3, 2025

uploaded to hackage today

@shayne-fletcher shayne-fletcher requested a review from a team as a code owner May 3, 2025 22:44
@shayne-fletcher
Copy link
Contributor Author

@dylant-da do you have an account on hackage? can i have the details (to my gmail) and we can get you listed you as a maintainer?

@dylant-da
Copy link
Contributor

I should have an account on hackage, but I haven't used it in a while, so it might have gotten culled. Let me check.

Copy link
Contributor

@dylant-da dylant-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'd like to confirm a question before merging

[ "rts/include"
, "rts/include/stg"
#if __GLASGOW_HASKELL__ == 910 || __GLASGOW_HASKELL__ == 908
#if __GLASGOW_HASKELL__ == 910
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason we're dropping 908 here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch. have pushed again with "the right" fix. it's busy work. the hackage linter won't allow us to upload a package with an empty directory so this has to be guarded against. it used to allow this but it became stricter.

Copy link
Contributor

@dylant-da dylant-da May 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Sounds good, approved and merged now :)

@dylant-da dylant-da enabled auto-merge (squash) May 12, 2025 07:44
@dylant-da dylant-da merged commit b7f38f0 into digital-asset:master May 12, 2025
43 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 12, 2025
@shayne-fletcher shayne-fletcher deleted the ghc-9.10.2 branch May 12, 2025 10:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants