-
Notifications
You must be signed in to change notification settings - Fork 10
new flavor ghc-9.10.2 #599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@dylant-da do you have an account on hackage? can i have the details (to my gmail) and we can get you listed you as a maintainer? |
|
I should have an account on hackage, but I haven't used it in a while, so it might have gotten culled. Let me check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I'd like to confirm a question before merging
| [ "rts/include" | ||
| , "rts/include/stg" | ||
| #if __GLASGOW_HASKELL__ == 910 || __GLASGOW_HASKELL__ == 908 | ||
| #if __GLASGOW_HASKELL__ == 910 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason we're dropping 908 here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch. have pushed again with "the right" fix. it's busy work. the hackage linter won't allow us to upload a package with an empty directory so this has to be guarded against. it used to allow this but it became stricter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Sounds good, approved and merged now :)
9117a9d to
71c45d8
Compare
uploaded to hackage today