Skip to content

Conversation

@shayne-fletcher
Copy link
Contributor

this needs rebasing on master after #606 has landed

recent commits (e.g. https://gitlab.haskell.org/ghc/ghc/-/commit/26dbcf616378afed9da9d50b5357786f3bd7ff9d) moved some ghc-heap files into ghc-internal causing some churn breaking the build since friday. this seems to be enough to fix it for now.

@shayne-fletcher shayne-fletcher requested a review from a team as a code owner September 3, 2025 00:44
@shayne-fletcher shayne-fletcher mentioned this pull request Sep 3, 2025
@dylant-da
Copy link
Contributor

Do these changes mean we can revert windows-2025 back to windows-latest in this PR?

@shayne-fletcher
Copy link
Contributor Author

no. these changes are unrelated.

@shayne-fletcher
Copy link
Contributor Author

@dylant-da the build has been broken since at least fri last week and we are not getting signal. i have already sunk significant hours into working out this fix. can we please make progress on this PR?

@dylant-da dylant-da enabled auto-merge (squash) September 4, 2025 12:57
@dylant-da
Copy link
Contributor

dylant-da commented Sep 4, 2025

Sorry, I wanted to take a proper look into the Windows fix since we've had similar problems on our end - I've approved/merged 606 and resolved merge conflicts on this PR / approved.

@shayne-fletcher
Copy link
Contributor Author

Sorry, I wanted to take a proper look into the Windows fix since we've had similar problems on our end

let me know what you find out please! 😢

@shayne-fletcher
Copy link
Contributor Author

suggest this could relate in some way to a change in the C-preprocessor and perhaps a latent case sensitive filepath issue.

@dylant-da dylant-da merged commit a08e155 into digital-asset:master Sep 4, 2025
46 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 4, 2025
@shayne-fletcher shayne-fletcher deleted the ghc-heap-file-move branch September 4, 2025 14:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants