change ghc-internal handling #608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@dylant-da any chance we can get this tested and merged please? |
Contributor
Author
|
@dylant-da @paulbrauner-da little help please? |
dylant-da
approved these changes
Sep 10, 2025
Contributor
dylant-da
left a comment
dylant-da
left a comment
There was a problem hiding this comment.
Sorry about the delay on this, it looks good, thank you for getting this through.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
more files were moved around and into ghc-internal [*] breaking the build. this was a forcing function to change and simplify ghc-internal handling. it's got more regular fortunately. the build should be fixed with this and we can continue
[*] e.g. https://gitlab.haskell.org/ghc/ghc/-/commit/39e1b7cb8cdf09d7782e0d8f1cb7779374349994