Fix loosepixel animation#4
Open
kercre123 wants to merge 4 commits into
Open
Conversation
|
Thanks. Will take a look once the 1.8.0 release is out the door. |
Contributor
Author
I thought that it could be useful for the 1.8 release, since this animation is already implemented as a level one shake reaction in the RCs and this PR just polishes that. It wasn't in the 1.7 release, so this could be something cool to put in the changelog. |
Contributor
Author
It looks like the v2.0 prod software still has the broken loosepixel animation, just want to quickly remind that this PR exists |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In anim_rtshake_lv1onground_loosepixel_01, the eyes and sprite are overlaid on top of each other and are out of sync. I made the eyes go out of view while the sprite is playing. The eyes and sprite are overlaid in the onhand one as well, but they are in sync there. This also needs to be done to binaryeyes but that doesn't seem to be used in any animationGroup yet.