Skip to content

Target Ruby 3.4 #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Target Ruby 3.4 #126

wants to merge 10 commits into from

Conversation

floriandejonckheere
Copy link
Collaborator

@floriandejonckheere floriandejonckheere commented Mar 25, 2024 •
edited
Loading

Add Ruby 3.3 and 3.4 to the CI version matrix.
Remove Ruby 3.1 (EoL) from the CI version matrix.

Fix test suite for Ruby main

Other fixes

  • Add keyword arguments to the method_missing in Polyphony::ResourcePool. Resolves instances of redis.set("key", "value", ex:5)
  • Cancel Github Actions runs in progress when pushing a new commit

@floriandejonckheere floriandejonckheere force-pushed the ruby-3-3 branch 3 times, most recently from 4c257f4 to 29df9b2 Compare March 25, 2024 09:15
@floriandejonckheere floriandejonckheere force-pushed the ruby-3-3 branch 2 times, most recently from 035709c to 507a965 Compare September 16, 2024 10:11
@floriandejonckheere floriandejonckheere marked this pull request as ready for review September 16, 2024 11:06
@floriandejonckheere
Copy link
Collaborator Author

@noteflakes The io_uring tests on CI are hanging, but I could not reproduce it locally. Do you know what could be the issue?

@PascalVanVlaenderen
Copy link

Can we get an update on this?

@noteflakes
Copy link
Collaborator

Hi Florian, I don't really have time to maintain Polyphony anymore. I added you as maintainer. Please feel free to merge PRs as you see fit. Thanks!

@floriandejonckheere
Copy link
Collaborator Author

Thanks! I'll try to keep an eye on the repository.

@floriandejonckheere floriandejonckheere changed the title Target Ruby 3.3 Target Ruby 3.3=4 Apr 29, 2025
@floriandejonckheere floriandejonckheere changed the title Target Ruby 3.3=4 Target Ruby 3.4 Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@floriandejonckheere @PascalVanVlaenderen @noteflakes