Ensure options.credentialId uniqueness is enforced.
#202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When providing `options.credentialId`, the VC (or minimally, its `credentialId`) will be stored, even if no credential status is configured, so that uniqueness can be enforced on `options.credentialId` alone.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #202 +/- ##
=======================================
Coverage 91.36% 91.37%
=======================================
Files 17 17
Lines 3371 3372 +1
=======================================
+ Hits 3080 3081 +1
Misses 291 291
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When providing
options.credentialId, the VC (or minimally, thecredentialIdvalue) will be stored, even if no credential status is configured, so that uniqueness can be enforced onoptions.credentialIdalone. To continue to issue VCs without any storage, do not provideoptions.credentialIdas usual.