Skip to content

Do not light torch by default; provide property to do so. #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 27, 2025

Conversation

msporny
Copy link
Member

@msporny msporny commented Apr 26, 2025

This PR does the following things:

  • Changes the default behavior of the torch to be unlit by default.
  • Provides a to automatically light the torch when initialized.

@msporny msporny requested review from dlongley and jameseaster April 26, 2025 16:32
@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 0.87%. Comparing base (4239c40) to head (f94b46a).

Files with missing lines Patch % Lines
components/BarcodeScanner.vue 0.00% 4 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main     #11   +/-   ##
=====================================
  Coverage   0.87%   0.87%           
=====================================
  Files          3       3           
  Lines        114     114           
  Branches      18      18           
=====================================
  Hits           1       1           
  Misses       113     113           
Files with missing lines Coverage Δ
components/BarcodeScanner.vue 1.06% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4239c40...f94b46a. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dlongley dlongley merged commit 9de089e into main Apr 27, 2025
3 checks passed
@dlongley dlongley deleted the add-light-torch branch April 27, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants