generated from digitalbazaar/bedrock-module-template-http
-
Notifications
You must be signed in to change notification settings - Fork 0
Use Barcode Detection API #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
c2a52a8
Use Barcode Detection API to detect barcodes.
jameseaster 15e8fe2
Start iOS camera at zoom level 2.
jameseaster 36f633c
Isolate detectBarcode function.
jameseaster 1a3aeef
Isolate helper functions.
jameseaster 545f7fa
Refactor detectBarcodes function.
jameseaster 6b621b2
Apply code review suggestions.
jameseaster 9497a7d
Apply suggestions from code review.
jameseaster dfe5876
Style fixes from code review.
jameseaster 3165e1a
Ignore scan cancellation and log other errors while closing scanner.
jameseaster File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
/*! | ||
* Copyright (c) 2025 Digital Bazaar, Inc. All rights reserved. | ||
*/ | ||
export function detectBarcodes({barcodeDetector, video, signal} = {}) { | ||
jameseaster marked this conversation as resolved.
Show resolved
Hide resolved
|
||
return new Promise((resolve, reject) => { | ||
// schedule barcode detection | ||
video.requestVideoFrameCallback(() => _detect({ | ||
barcodeDetector, video, signal, resolve, reject | ||
})); | ||
}); | ||
} | ||
|
||
async function _detect({barcodeDetector, video, signal, resolve, reject}) { | ||
try { | ||
// detect barcodes in the current video frame | ||
const barcodes = await barcodeDetector.detect(video); | ||
if(barcodes.length > 0) { | ||
return resolve(barcodes); | ||
} | ||
// abort as needed | ||
signal?.throwIfAborted(); | ||
// no barcodes found, schedule to try again | ||
video.requestVideoFrameCallback(() => _detect({ | ||
barcodeDetector, video, signal, resolve, reject | ||
})); | ||
} catch(error) { | ||
reject(error); | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that if this component can do more than one scan (before it has to go out of scope or get cleaned up or whatever by Vue), then we'll need a new
AbortController
for each scan. Otherwise it will always abort after the first abort and never scan again.