Restore vue-router v4 support in the peer dependency range. - #23
Open
jameseaster wants to merge 2 commits into
Open
Restore vue-router v4 support in the peer dependency range.#23jameseaster wants to merge 2 commits into
jameseaster wants to merge 2 commits into
Conversation
This was referenced Sep 1, 2026
dlongley
approved these changes
Sep 2, 2026
dlongley
left a comment
dlongley
left a comment
Member
There was a problem hiding this comment.
Approving with the needed note in the changelog. We should release v6 shortly after this with vue-router v5 and move on from v5 wherever possible.
| on v4. The range is now `^4.0.15 || ^5.0.0`. Both majors work: this library | ||
| imports nothing from `vue-router` and calls only `addRoute`, `currentRoute` | ||
| and `beforeEach` on the router the host app supplies, none of which changed | ||
| in v5. |
Member
There was a problem hiding this comment.
Suggested change
| in v5. | |
| in v5. This is an unusual measure to support two different major versions | |
| of a peer dependency; upgrading to version 6 is strongly recommended, it | |
| will only support a single major version of peer dependencies. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Widens the
vue-routerpeer range to^4.0.15 || ^5.0.0. 5.2.0 replaced^4.0.15with^5.1.0instead of widening it, which leaves the release unresolvable for any consumer still on v4. Nothing here importsvue-router, and the only calls areaddRoute,currentRouteandbeforeEach, all unchanged in v5, so both majors work. Verified by packing this as 5.2.1 and installing it into a webpack-based host app onvue-router@5.3.0: strictnpm installresolves, the bundle builds, the app serves. Background in #22. Second commit drops an unrelated stale eslint-disable.