Skip to content

Coastal change country#459

Merged
mickwelli merged 27 commits intomainfrom
coastal-change-country
May 21, 2025
Merged

Coastal change country#459
mickwelli merged 27 commits intomainfrom
coastal-change-country

Conversation

@fangfy
Copy link
Contributor

@fangfy fangfy commented Jun 21, 2023

Proposed changes

Include a brief description of the changes being proposed, and why they are necessary.

Checklist (replace [ ] with [x] to check off)

  • Remove any unused Python packages from Load packages
  • Remove any unused/empty code cells
  • Remove any guidance cells (e.g. General advice)
  • Ensure that all code cells follow the PEP8 standard for code. The jupyterlab_code_formatter tool can be used to format code cells to a consistent style: select each code cell, then click Edit and then one of the Apply X Formatter options (YAPF or Black are recommended)
  • Include relevant tags in the first notebook cell and re-use tags if possible
  • Ensure appropriate colour schemes have been used to maximise accessibility for vision impairment. Test your images or learn more with Coblis or TPGI
  • Clear all outputs, run notebook from start to finish, and save the notebook in the state where all cells have been sequentially evaluated

Copy link
Contributor

@mickwelli mickwelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool notebooks, I think the bar charts and text statements are especially interesting.

I've committed and pushed a few markdown edits I made as I went along. Additionally, under executed cell 7 I suggest the following change:

“We can inspect the distributions of the good measurements and the significant changes. Significant changes have a significance (p-value) of less than 0.01, which indicates a shoreline is measured to have undergone consistent change through time.”
Suggest revision to:
“We can inspect the distributions of the good measurements and the significant changes. Changes with a p-value of less than 0.01 indicate that a shoreline has undergone change greater than would be expected with natural variation.”

In the sea level rise notebook I cannot find the slr_data folder, wondering if this is missing or whether this needs to be downloaded by the user?

@mickwelli
Copy link
Contributor

@nanaboamah89 @mpho-sadiki noting here (as a self-reminder) that we'll need to update the population stats in this PR then update the tables in the coastlines dashboard

@nanaboamah89
Copy link
Contributor

HI @mickwelli, @mpho-sadiki when I changed the version from https://deafrica-services.s3.af-south-1.amazonaws.com/coastlines/v0.4.0/deafricacoastlines_v0.4.0.gpkg to https://deafrica-services.s3.af-south-1.amazonaws.com/coastlines/v0.4.2/deafricacoastlines_v0.4.2.gpkg from Combine coastline change information with gridded population data to estimate exposure step, all the results show 0.

I also can't seem to change the year.

Copy link
Contributor

@lisarebelo lisarebelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to publish this one now that the dashboard has been launched, as a companion tool and to disaggregate changes and impacts further (e.g. sub-national level).

@mickwelli
Copy link
Contributor

HI @mickwelli, @mpho-sadiki when I changed the version from https://deafrica-services.s3.af-south-1.amazonaws.com/coastlines/v0.4.0/deafricacoastlines_v0.4.0.gpkg to https://deafrica-services.s3.af-south-1.amazonaws.com/coastlines/v0.4.2/deafricacoastlines_v0.4.2.gpkg from Combine coastline change information with gridded population data to estimate exposure step, all the results show 0.

I also can't seem to change the year.

@nanaboamah89 @mpho-sadiki Looks like there was an issue with xarray alignment following changes to the xr_rasterize() function.

@mickwelli mickwelli marked this pull request as ready for review May 6, 2025 07:28
@mpho-sadiki
Copy link
Contributor

HI @mickwelli, @mpho-sadiki when I changed the version from https://deafrica-services.s3.af-south-1.amazonaws.com/coastlines/v0.4.0/deafricacoastlines_v0.4.0.gpkg to https://deafrica-services.s3.af-south-1.amazonaws.com/coastlines/v0.4.2/deafricacoastlines_v0.4.2.gpkg from Combine coastline change information with gridded population data to estimate exposure step, all the results show 0.
I also can't seem to change the year.

@nanaboamah89 @mpho-sadiki Looks like there was an issue with xarray alignment following changes to the xr_rasterize() function.

Nice fix @mickwelli. It runs well now.

@mickwelli mickwelli merged commit 14240b4 into main May 21, 2025
1 check passed
@fangfy fangfy deleted the coastal-change-country branch September 17, 2025 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants