Skip to content

Iwmi volume#575

Merged
mickwelli merged 23 commits intomainfrom
iwmi_volume
Apr 27, 2025
Merged

Iwmi volume#575
mickwelli merged 23 commits intomainfrom
iwmi_volume

Conversation

@mickwelli
Copy link
Contributor

@mickwelli mickwelli commented Feb 21, 2025

Proposed changes

PR for the volume calculation notebook prepared by IWMI.

Checklist (replace [ ] with [x] to check off)

  • Remove any unused Python packages from Load packages
  • Remove any unused/empty code cells
  • Remove any guidance cells (e.g. General advice)
  • Ensure that all code cells follow the PEP8 standard for code. The jupyterlab_code_formatter tool can be used to format code cells to a consistent style: select each code cell, then click Edit and then one of the Apply X Formatter options (YAPF or Black are recommended)
  • Include relevant tags in the first notebook cell and re-use tags if possible
  • Ensure appropriate colour schemes have been used to maximise accessibility for vision impairment. Test your images or learn more with Coblis or TPGI
  • Clear all outputs, run notebook from start to finish, and save the notebook in the state where all cells have been sequentially evaluated

Closes issues (optional)

  • Closes Issue #000

@nanaboamah89
Copy link
Contributor

nanaboamah89 commented Feb 21, 2025

Great work by the IWMI team! I have made some update to the notebook. If the notebook is divided into five separate notebooks it will improve its structure:

  1. Ends at the data processing stage.
  2. Starts from data processing and ends at model preparation and training.
  3. Starts from model preparation and training and ends at data preparation and feature selection.
  4. Starts from data preparation and ends at feature selection, prediction of dam levels, and conversion to volumes using the rating curve.
  5. Covers the prediction of dam levels and conversion to volumes using the rating curve.

The Embed into project background section can be added to the Background at the beginning of the notebook. The References should come before the Additional Information.

@KayathriIWMI KayathriIWMI marked this pull request as ready for review March 7, 2025 04:35
Copy link
Contributor

@nanaboamah89 nanaboamah89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, made some minor changes to it, aside that everything is fine.

@nanaboamah89 nanaboamah89 requested a review from lisarebelo April 16, 2025 12:53
Copy link
Contributor

@lisarebelo lisarebelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to have this collection of notebooks developed. They are well laid out and presented. A few minor edits:

01:
Under Analysis parameters - it is mentioned that the geohash can be found from Maps - add a link to waterbodies in Maps

All notebooks:

  • under Analysis Parameters (01) add of to "geohash a waterbody"
  • DEA is Digital Earth Australia. Please change all references from DEA to DE Africa in all notebooks
  • It is not clear what the last heading means "Embed into project background:" - it seems to be an acknowledgement? The title needs editing.

@KayathriIWMI
Copy link
Collaborator

Hi @lisarebelo, thank you for your time and support in reviewing.
Regarding the comment "Embed into project background:", would it be alright if I rephrase it as "Project Background" for clarity?

@lisarebelo
Copy link
Contributor

Hi @lisarebelo, thank you for your time and support in reviewing. Regarding the comment "Embed into project background:", would it be alright if I rephrase it as "Project Background" for clarity?

Yes that would work, thanks @KayathriIWMI

@mickwelli mickwelli merged commit af1d542 into main Apr 27, 2025
1 check passed
@mickwelli mickwelli deleted the iwmi_volume branch April 27, 2025 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants