Conversation
tested dam model
structural changes
|
Great work by the IWMI team! I have made some update to the notebook. If the notebook is divided into five separate notebooks it will improve its structure:
The Embed into project background section can be added to the Background at the beginning of the notebook. The References should come before the Additional Information. |
nanaboamah89
left a comment
There was a problem hiding this comment.
Great work, made some minor changes to it, aside that everything is fine.
lisarebelo
left a comment
There was a problem hiding this comment.
Great to have this collection of notebooks developed. They are well laid out and presented. A few minor edits:
01:
Under Analysis parameters - it is mentioned that the geohash can be found from Maps - add a link to waterbodies in Maps
All notebooks:
- under Analysis Parameters (01) add of to "geohash a waterbody"
- DEA is Digital Earth Australia. Please change all references from DEA to DE Africa in all notebooks
- It is not clear what the last heading means "Embed into project background:" - it seems to be an acknowledgement? The title needs editing.
|
Hi @lisarebelo, thank you for your time and support in reviewing. |
Yes that would work, thanks @KayathriIWMI |
Proposed changes
PR for the volume calculation notebook prepared by IWMI.
Checklist (replace
[ ]with[x]to check off)Load packagesGeneral advice)jupyterlab_code_formattertool can be used to format code cells to a consistent style: select each code cell, then clickEditand then one of theApply X Formatteroptions (YAPForBlackare recommended)Closes issues (optional)