Don't send mail to warn user fill timesheet (weekend and holiday) - #206
Open
bport wants to merge 1 commit into
Open
Don't send mail to warn user fill timesheet (weekend and holiday)#206bport wants to merge 1 commit into
bport wants to merge 1 commit into
Conversation
bport
force-pushed
the
dont_send_timesheet_mail_we
branch
from
February 23, 2025 22:22
dab2129 to
bc814bf
Compare
bport
changed the title
bport
marked this pull request as ready for review
February 23, 2025 22:23
digitalfox
reviewed
Feb 25, 2025
digitalfox
left a comment
digitalfox
left a comment
Owner
There was a problem hiding this comment.
The same code already exists here (except the async decorator)
Line 48 in 203991e
Even if the business rules if quite simple it may be better to factorize it (staffing/utils.py maybe ?)
bport
force-pushed
the
dont_send_timesheet_mail_we
branch
from
March 23, 2025 19:54
bc814bf to
3006ba7
Compare
…end / public holiday We still sent it in holidays, because we still want to warn manager for example
bport
force-pushed
the
dont_send_timesheet_mail_we
branch
from
March 23, 2025 21:27
3006ba7 to
55c97f4
Compare
digitalfox
reviewed
Mar 24, 2025
| import random | ||
| import pytz | ||
|
|
||
| from staffing.utils import is_outside_business_hours |
Owner
There was a problem hiding this comment.
This import cannot work so early in the file before env has been set. It fails with ModuleNotFoundError: No module named 'staffing'.
It should be moved around line 49 with others pydici imports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.