Refactor response handling to avoid exceptions on normal requests #2205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpscholten
force-pushed
the
response-without-exceptions
branch
5 times, most recently
from
928975e to
ff26324
Compare
Previously, every render/redirect threw a ResponseException which was caught by runAction. Now render/redirect call WAI's respond directly and return IO ResponseReceived. For early exits (accessDeniedUnless, notFoundWhen, basicAuth), a new earlyReturn helper throws EarlyReturnException after the response is sent. This should improve performance since exceptions are no longer thrown on every request - only for guard-based early exits. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Remove references to ResponseException which is no longer used. Document earlyReturn for conditional early exits. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Create standalone wai-early-return package with earlyReturn function and earlyReturnMiddleware - Add earlyReturnMiddleware to IHP.Server middleware chain - Remove IHP.Controller.EarlyReturn module (moved to wai-early-return) - Update AutoRefresh to use middleware for early return handling - Add wai-early-return to nix overlay and devenv Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
mpscholten
force-pushed
the
response-without-exceptions
branch
from
ff26324 to
f977088
Compare
- Add errorHandlerMiddleware that catches all exceptions and displays appropriate error pages based on exception type and environment - Store action type in request vault so error messages can identify which action was running when the exception occurred - Wrap routing exceptions in RouterException newtype to distinguish them from action exceptions - Remove inline exception handling from runAction and frontControllerToWAIApp - Export writeLog from IHP.Log for direct logger access - Add wai-early-return to .ghci include paths Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, every render/redirect threw a ResponseException which was caught by runAction. Now render/redirect call WAI's respond directly and return IO ResponseReceived.
For early exits (accessDeniedUnless, notFoundWhen, basicAuth), a new earlyReturn helper throws EarlyReturnException after the response is sent.
This should improve performance since exceptions are no longer thrown on every request - only for guard-based early exits.
Relates to #2148