Move ActionType to WAI request vault #2225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows `isActiveController` to work with just `?request` instead of requiring `?context`, making it usable in more contexts. - Add new IHP.ActionType module with ActionType, setActionType, and isActiveController - Store ActionType in WAI request vault in runAction' before creating controller context - Remove ActionType from controller context (no longer needed there) - Re-export isActiveController from ViewSupport for backward compatibility - Add wai-request-params to .ghci for test environment Co-Authored-By: Claude Opus 4.5 <[email protected]>
Updates view helpers to use ?request.frameworkConfig instead of ?context.frameworkConfig, since frameworkConfig is already in the request vault. Functions updated: - theCSSFramework - fromCSSFramework - liveReloadWebsocketUrl - renderFlashMessages / theFlashMessages - renderBreadcrumb - createFormContext / formFor' Co-Authored-By: Claude Opus 4.5 <[email protected]>
The renderBreadcrumb function now requires ?request instead of ?context. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ActionTypefrom controller context to WAI request vaultisActiveControllernow works with just?requestinstead of requiring?contextIHP.ActionTypemodule with cleaner APIChanges
IHP.ActionTypemodule: ContainsActionType,setActionType,requestActionType, andisActiveControllerIHP.RouterSupport: InsertsActionTypeinto vault viasetActionTypeinrunAction'IHP.ViewSupport: Re-exportsisActiveControllerfromActionTypefor backward compatibilityIHP.ControllerSupport: RemovesputContextcall forActionType(no longer needed)IHP.Controller.Context: Re-exportsActionTypefrom the new moduleTest plan
🤖 Generated with Claude Code