Use Text instead of String in pathTo for better performance #2226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add actionPrefixText and stripActionSuffixText functions that use efficient Text operations (Text.isPrefixOf, Text.stripSuffix, Text.breakOn) instead of recursive char-by-char String traversal. Update pathTo to use these Text functions, reducing Text.pack calls in the hot path. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Replace usages of actionPrefix with Text.encodeUtf8 (actionPrefixText ...) and delete the old String-based functions that are no longer needed. Also removes unused Data.Char import. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
actionPrefixTextfunction that usesText.isPrefixOfandText.breakOninstead of manual char-by-char pattern matchingstripActionSuffixTextfunction that usesText.stripSuffixinstead of recursive String traversalpathToto use these Text functions, reducingText.packcalls in the hot pathThe
pathTofunction is called frequently for URL generation. This change moves more of the computation to use efficient Text operations instead of building Strings and converting at the end.Test plan
echo ':l ihp/IHP/RouterSupport.hs' | ghciecho -e ':l ihp-ide/Test/Main.hs\nmain' | ghci🤖 Generated with Claude Code