Fix flash messages and improve test middleware stack #2232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- callActionWithParams now runs the complete middleware stack per request - Build real HTTP requests with form-encoded bodies - Preserve mock sessions from withUser - runTestMiddlewares simplified for initial setup only Co-Authored-By: Claude Opus 4.5 <[email protected]>
- renderHtml now takes ?request as implicit parameter - render passes the modified request with flashVaultKey - Layout functions updated with ?request constraint Previously renderHtml was using frozenContext.request which didn't have flashVaultKey in the vault, causing "consumeFlashMessagesMiddleware was not called" errors. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Member
Author
|
@amitaibu this should fix the tests in tpp-app |
This ensures tests using runActionWithNewContext have the ActionType set in the request vault, matching the behavior of runAction' in RouterSupport. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
flashVaultKeyin vault) torenderHtmlwithUserwhen running through middleware stackProblem
renderHtmlwas usingfrozenContext.requestwhich didn't haveflashVaultKeyin the vault. The flash messages middleware addsflashVaultKeyto the request it passes tonext, but this modified request wasn't being used when rendering views.Test plan
withUsermock sessions work correctly🤖 Generated with Claude Code