Fix sqlExecDiscardResult to use noResult decoder#2452
Merged
mpscholten merged 1 commit intomasterfrom Feb 19, 2026
Merged
Conversation
…cted sqlExecDiscardResult was delegating to sqlExec which uses sqlExecHasqlCount (Decoders.rowsAffected). This fails for SQL commands like SET CONSTRAINTS ... DEFERRED that don't return a row count in their command tag, causing UnexpectedResultStatementError "Empty bytes". Now delegates to sqlExecHasql which uses Decoders.noResult instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sqlExecDiscardResultwas delegating tosqlExecwhich usessqlExecHasqlCount(Decoders.rowsAffected). This fails for SQL commands that don't return a row count in their command tag (e.g.SET CONSTRAINTS ... DEFERRED), causingUnexpectedResultStatementError "Empty bytes".sqlExecHasqlwhich usesDecoders.noResultinstead.Test plan
ghc --make -fno-codesqlExecDiscardResult "SET CONSTRAINTS ... DEFERRED" ()no longer throwsHasqlSessionError🤖 Generated with Claude Code