Skip to content

Fix job worker reliability: retry on error, reduce poll interval #2453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mpscholten merged 1 commit into from
Feb 19, 2026
+1 −0
Merged

Fix job worker reliability: retry on error, reduce poll interval #2453

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ihp/IHP/Job/Runner.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,7 @@ jobWorkerFetchAndRunLoop JobWorkerArgs { .. } = do
Left exception -> do
Log.error ("Job worker: Failed to fetch next job: " <> tshow exception)
Concurrent.threadDelay 1000000 -- 1s backoff to avoid tight error loops
runJobLoop -- retry after transient error
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Stop retry loop when worker shutdown is requested

Re-entering runJobLoop after every fetch error means an active worker never terminates while the database keeps failing, so the dispatcher’s Stop path can block indefinitely waiting for activeCount == 0 during shutdown. This is a regression from the previous behavior (worker exited on fetch failure): with subscriptions/poller already stopped, there is no new work to drain, but this retry loop keeps the worker alive forever unless a second forced cancellation signal is sent.

Useful? React with 👍 / 👎.

Right (Just job) -> do
Log.info ("Starting job: " <> tshow job)

Expand Down