Recreate job notification triggers after PGListener reconnects#2458
Merged
mpscholten merged 2 commits intomasterfrom Feb 19, 2026
Merged
Recreate job notification triggers after PGListener reconnects#2458mpscholten merged 2 commits intomasterfrom
mpscholten merged 2 commits intomasterfrom
Conversation
After `make db` drops and recreates the database, pg_notify triggers are destroyed. PGListener reconnects and re-LISTENs correctly, but without triggers pg_notify never fires, causing ~40s delays until the poller picks up jobs. Add a reconnection callback mechanism to PGListener that fires after connection recovery. The job queue registers a callback to recreate its notification triggers on the PGListener's own connection, avoiding pool staleness issues. Fixes: amitaibu/ihp-sensors#18 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 628db0fba3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Addresses review feedback: HasqlConnection.use can fail transiently (e.g. if the job table doesn't exist yet during reconnect). Log warnings on failure and info on success instead of silently discarding the result. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
|
I'll try this PR on my repo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PGListenerthat fires after connection recovery, giving callers the liveHasql.Connectionto run SQL directlypg_notifytriggers on reconnect, fixing ~40s delays aftermake dbdrops the databasepg_notifysubscription callback for better observabilityContext
After
make dbdrops and recreates the database, the notification triggers that firepg_notifyare destroyed. PGListener reconnects and re-LISTENs correctly, but without triggerspg_notifynever fires. Jobs are only picked up by the 60-second poller (average ~30-40s delay).Fixes: https://github.com/amitaibu/ihp-sensors/issues/18
Test plan
ihp-pglistener/IHP/PGListener.hsandihp/IHP/Job/Queue.hsmake dbwhile job worker is running, verify jobs are picked up immediately viapg_notify(not delayed by poller)🤖 Generated with Claude Code