Skip to content

fix(databases): make --user optional for pool create (#1758) #1766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DeveloperViraj wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(databases): make --user optional for pool create (#1758) #1766

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10e4150
fix(databases): make --user optional for pool create (#1758)
DeveloperViraj Oct 7, 2025
d3eeb6f
Merge branch 'main' into fix/databases-pool-optional-user
DO-rrao Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions commands/databases.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1319,7 +1319,6 @@ func RunDatabasePoolCreate(c *CmdConfig) error {

return displayDatabasePools(c, *pool)
}

func buildDatabaseCreatePoolRequestFromArgs(c *CmdConfig) (*godo.DatabaseCreatePoolRequest, error) {
req := &godo.DatabaseCreatePoolRequest{Name: c.Args[1]}

Expand All @@ -1335,17 +1334,17 @@ func buildDatabaseCreatePoolRequestFromArgs(c *CmdConfig) (*godo.DatabaseCreateP
}
req.Size = size

db, err := c.Doit.GetString(c.NS, doctl.ArgDatabasePoolDBName)
db, err := c.Doit.GetString(c.NS, doctl.ArgDago version
tabasePoolDBName)
if err != nil {
return nil, err
}
req.Database = db

user, err := c.Doit.GetString(c.NS, doctl.ArgDatabasePoolUserName)
if err != nil {
return nil, err
user, _ := c.Doit.GetString(c.NS, doctl.ArgDatabasePoolUserName)
if user != "" {
req.User = user
}
req.User = user

return req, nil
}
Expand Down