Support gateway default route #1787
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johannaratliff
approved these changes
Nov 6, 2025
asaha2
force-pushed
the
asaha/LBAAS-4224
branch
from
5a7d349 to
c556fef
Compare
asaha2
force-pushed
the
asaha/LBAAS-4224
branch
from
c556fef to
d88c14c
Compare
Contributor
|
Can you add a test case to cover these changes ? rest LGTM 🚀 |
harshmaru7
approved these changes
Nov 24, 2025
Oghenesuvwe-dev
pushed a commit
to Oghenesuvwe-dev/doctl
that referenced
this pull request
Nov 25, 2025
* Support gateway default route * Fix timeout rendering * Add unit test
Oghenesuvwe-dev
added a commit
to Oghenesuvwe-dev/doctl
that referenced
this pull request
Nov 26, 2025
- Assign gateway data on every VPC iteration, not just first - Removes zero-value struct issue causing incomplete row data - Fixes PR digitalocean#1787 regression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VPCsinto separateVPC/GatewayIP/Defaultcolumns, each uniquely getting own rows