Repository navigation
fix(byoip): honor ListOptions in BYOIPPrefixes.GetResources - #1215
Open
pcbeingused333 wants to merge 2 commits into
Open
pcbeingused333 wants to merge 2 commits into
pcbeingused333 wants to merge 2 commits into
Conversation
addOptions result was discarded, so Page and PerPage never reached the request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the
BYOIPPrefixes.GetResourcespagination bug:ListOptionswas ignored (found by code review, no issue filed).Cause:
GetResourcescalledaddOptions(path, opt)and discarded both the returned URL and the error, soPageandPerPagewere never sent. Asking for page 2 returned page 1. The siblingListin the same file assignspath, err := addOptions(path, opt)correctly.Fix: use the returned path and return the error, same as
List.Tests:
TestBYOIPPrefixes_GetResourcesListOptionsinbyoip_prefixes_test.goassertspage=2&per_page=50reach the request. Red before the fix, green after;go test .andgo vet .pass.Disclosure: this change was prepared with an AI coding assistant (Claude) and submitted by the account owner.