Repository navigation
Aidc 1782/add publicapi godo - #1218
Open
jinyoungoh-public wants to merge 7 commits into
Open
jinyoungoh-public wants to merge 7 commits into
jinyoungoh-public wants to merge 7 commits into
Conversation
jinyoungoh-public
force-pushed
the
AIDC-1782/add-publicapi-godo
branch
from
November 16, 2026 20:13
a808253 to
cf8fa97
Compare
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
jinyoungoh-public
force-pushed
the
AIDC-1782/add-publicapi-godo
branch
from
November 18, 2026 18:07
8ffb74c to
c90448a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an ADS (Agent Data Services) Go client to godo under /v2/data-cloud-platform: workspaces, tokens, secrets, query credentials, and data flows.
Field names follow the public API JSON contract. ListTokens exposes workspace_uuid / workspace_uuids only (no sandbox fields in the Go client).
Note on data-flow URLs: all data-flow / fchain / metrics routes include region as a required path segment:
/v2/data-cloud-platform/{region}/workspaces/{workspace}/data-flows...
Region is path-only (json:"-" / url:"-" on request structs; not sent in JSON bodies), CreateToken-style. PUT-only for secret write (no POST alias). Rewind is implemented; unsupported server responses are surfaced as normal API errors, not client bugs.
Release note for API Engineering
Did not bump libraryVersion or edit CHANGELOG.md in this feature PR.
Test plan
gofmt on touched ads*.go files
go vet .
Unit tests for every method: success body, path/query escaping, and at least one error response
Fake secrets only (secret_value); no real tokens/passwords
CreateToken uses workspace_uuids (not sandbox_uuids)
Optional 403 coverage for auth denial (server-side IAM; client surfaces *ErrorResponse): GetWorkspace, CreateToken, GetWorkspaceSecret, GetWorkspaceQueryCredentials, GetDataFlow
go test -count=1 -run 'ADS' .
Also: gofmt -l ads*.go (clean) and go vet . (clean).
Unit test layout:
ads_test.go — plans, workspaces, tokens, put secret (+ some 403s)
ads_more_test.go — get/list/delete secrets, query credentials, data flows, actions, fchain, metrics (+ 403s)
TestADS* cases covering success / escape / error (and selected forbidden) paths