Repository navigation
databases: always send tls for rsyslog logsink updates - #1223
Open
pcbeingused333 wants to merge 2 commits into
Open
pcbeingused333 wants to merge 2 commits into
pcbeingused333 wants to merge 2 commits into
Conversation
DatabaseUpdateLogsinkRequest marshaled TLS with omitempty, so an explicit TLS: false was dropped from the PUT body even though the API requires tls for rsyslog sinks. Add a MarshalJSON, mirroring the one on DatabaseCreateLogsinkRequest, that keeps tls for rsyslog configs and still omits it for Elasticsearch/OpenSearch configs. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #906, which fixed this for
CreateLogsink; this coversUpdateLogsink.Root cause.
DatabaseUpdateLogsinkRequestembedsDatabaseLogsinkConfig, whoseTLSfield is taggedjson:"tls,omitempty".UpdateLogsinktherefore drops an explicitTLS: falsefrom the PUT body, although the API spec requirestlsfor rsyslog sinks (required: server, port, tls, format).Fix. Add
MarshalJSONonDatabaseUpdateLogsinkRequest, mirroring the create request: when the config looks like rsyslog (server/port/format set)tlsis always emitted; Elasticsearch/OpenSearch configs keep omitting it.Tests.
TestDatabases_UpdateLogsink_RsyslogKeepsTLSFalsechecks the request body contains"tls": false(fails before the change);TestDatabases_UpdateLogsink_OpensearchOmitsTLScheckstlsis still absent for OpenSearch configs. Fullgo test .passes.This change was prepared with the assistance of an AI coding tool (Claude) and submitted by a human contributor who is responsible for it.