Fixed light mode flash whilst loading #146
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bada bing bada bong
Nautman
requested changes
Feb 17, 2021
Member
Nautman
left a comment
Nautman
left a comment
There was a problem hiding this comment.
This seems to work, but I would prefer it if the code was indented according to the original style in the file. Right now you have made a newline spacing between html and the contents. Everything in the html is also de-indented. This isn't a very big deal but it would be nice if you could fix it. Please let me know if you have trouble doing so.
Member
|
I'll fix this when I have time :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As previously mentioned I guess this uses the native dark/light theme rather than from user settings
Still, no way to make this happen using js or ts. Maybe by backend-magic in the future.