Skip to content

feat/add-ci-and-linting #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kylehuynh205 merged 2 commits into from
Mar 27, 2026
Merged

feat/add-ci-and-linting #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c33eadf
fix: use phpcbf to fix linting errors
Aryan-R-Patel Mar 27, 2026
fc8dae6
feat: add ci testing workflow
Aryan-R-Patel Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
name: CI

on:
push:
branches: [ main ]
pull_request:
branches: [ main ]
workflow_dispatch:

jobs:
islandora-module-ci:
uses: digitalutsc/reusable_workflows/.github/workflows/islandora-module-ci.yml@main
with:
module_name: advanced_search_default_sort_override
install_chromedriver: false
13 changes: 7 additions & 6 deletions advanced_search_default_sort_override.module
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
* Contains advanced_search_tips.module.
*/

use \Drupal\Core\Routing\RouteMatchInterface;
use \Drupal\node\Entity\Node;
use Drupal\Core\Form\FormStateInterface;
use Drupal\Core\Routing\RouteMatchInterface;
use Drupal\views\ViewExecutable;

/**
Expand Down Expand Up @@ -38,8 +38,9 @@ function advanced_search_default_sort_override_theme() {

/**
* Implements hook_views_pre_build().
*
* Replaces hook_views_pre_view. This modifiees the live objects instead of the config array.
*
* Replaces hook_views_pre_view.
* This modifies the live objects instead of the config array.
*/
function advanced_search_default_sort_override_views_pre_build(ViewExecutable $view) {
// Only run on views except for the admin UI.
Expand All @@ -64,7 +65,7 @@ function advanced_search_default_sort_override_views_pre_build(ViewExecutable $v
/**
* Implements hook_form_FORM_ID_alter() for views_ui_config_item_form.
*/
function advanced_search_default_sort_override_form_views_ui_config_item_form_alter(&$form, \Drupal\Core\Form\FormStateInterface $form_state, $form_id) {
function advanced_search_default_sort_override_form_views_ui_config_item_form_alter(&$form, FormStateInterface $form_state, $form_id) {
// Only alter sort handler forms.
if ($form_state->get('type') !== 'sort') {
return;
Expand Down Expand Up @@ -94,7 +95,7 @@ function advanced_search_default_sort_override_form_views_ui_config_item_form_al
* into the saved handler options, since core's unpackOptions() only keeps
* options that are declared in the handler's defineOptions().
*/
function advanced_search_default_sort_override_config_item_form_submit(array &$form, \Drupal\Core\Form\FormStateInterface $form_state) {
function advanced_search_default_sort_override_config_item_form_submit(array &$form, FormStateInterface $form_state) {
$view = $form_state->get('view');
$display_id = $form_state->get('display_id');
$type = $form_state->get('type');
Expand Down