Skip to content

refactor: remove unused variable, improve doc comment #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kylehuynh205 merged 1 commit into from
Apr 21, 2026
Merged

refactor: remove unused variable, improve doc comment #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@ jobs:
uses: digitalutsc/reusable_workflows/.github/workflows/islandora-module-ci.yml@main
with:
module_name: islandora_iiif
install_chromedriver: false
install_chromedriver: false
2 changes: 1 addition & 1 deletion islandora_iiif.info.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@ description: 'IIIF support for Islandora'
core_version_requirement: ^9 || ^10 || ^11
package: Islandora
dependencies:
- islandora_lite:termwithuri_condition
- islandora_lite:termwithuri_condition
11 changes: 3 additions & 8 deletions src/Plugin/views/style/IIIFManifest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,8 +290,7 @@ protected function getTileSourceFromRow(ResultRow $row, $iiif_address, $iiif_bas
if (isset($entity->{$viewsField->definition['field_name']})) {
/** @var \Drupal\Core\Field\FieldItemListInterface $images */
$images = $entity->{$viewsField->definition['field_name']};
// phpcs:ignore -- Unused variable $i.
foreach ($images as $i => $image) {
foreach ($images as $image) {
if (!$image->entity->access('view')) {
// If the user does not have permission to view the file, skip it.
continue;
Expand Down Expand Up @@ -491,14 +490,10 @@ protected function getOcrUrl(EntityInterface $entity, int $id) {
/**
* Gets nodes that a media belongs to.
*
* // phpcs:ignore -- Doc comment for parameter $media does not match actual variable name $id
* @param \Drupal\media\MediaInterface $media
* The Media whose node you are searching for.
* @param \Drupal\Core\Entity\EntityInterface $entity
* The entity.
* @param int $id
* The ID of the book node.
* // phpcs:ignore -- Doc comment for parameter $entity does not match actual variable name <undefined>
* @param EntityInterface $entity
* The entity.
*
* @return \Drupal\node\NodeInterface
* Parent node.
Expand Down