refactor/phpcs-ignore-comments - #8
Merged
Merged
Conversation
…mplement dependency injection, and add translatino to options
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the codebase by renaming method names, deleting unused variables and methods, implementing dependency injection, and adding translatibility to options.
Changes
media_fits.module: Delete unused utility functions and rename method to use Drupal module file naming convention.src/Form/MediaFitsConfigForm.php: Add translation calls and implement dependency injection.src/Plugin/AdvancedQueue/JobType/MediaFitsJob.php: Delete unused variable.