Skip to content

Conversation

@8ctopus
Copy link

@8ctopus 8ctopus commented Oct 2, 2025

Great theme you made, here's my modest contribution;

This PR fixes a deprecation when using classicpress (a lighter wp without blocks)

Exception has occurred: Deprecated
Function add_theme_support( 'html5' ) was called with an argument that is <strong>deprecated</strong> since version CP-2.0.0! HTML5 is the default.

@height
Copy link

height bot commented Oct 2, 2025

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@ronilaukkarinen
Copy link
Member

@8ctopus Thanks for the PR, and sorry for missing it! So this PR doesn’t affect any existing functionality, right?

@8ctopus
Copy link
Author

8ctopus commented Dec 2, 2025

@ronilaukkarinen Hi Roni, no worries for the delay. I don't think it will break anything for WP users, did you try it in a WP install? In classicpress, it works just fine.

@ronilaukkarinen
Copy link
Member

@ronilaukkarinen Hi Roni, no worries for the delay. I don't think it will break anything for WP users, did you try it in a WP install? In classicpress, it works just fine.

Haven't tested it yet, this is why I'm asking. But we'll test it soon.

@8ctopus
Copy link
Author

8ctopus commented Dec 2, 2025

The global variable $cp_version is not defined in a standard wp install and is how classicpress recognizes itself, so IMO it's safe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants