Skip to content

Conversation

@ddNils
Copy link

@ddNils ddNils commented Nov 12, 2025

As I am working on a Windows machine, I needed to make sure, that docker-entrypoint would not include windows-style line breaks. Unfortunately my IDE was adding them on default so I added a line in the dockerfile to remove the line-breaks and adjust the permissions on docker-entrypoint before using it.

More importantly I added --disable-notifications to the chrome args to prevent notifications like " wants to show notifications" - block or allow - which was obstructing my recording.

great tool otherwise, really like it!

@digiz3d
Copy link
Owner

digiz3d commented Nov 14, 2025

Thanks for your PR ! I'm glad you like this tool 😃

The disable-notifications flag indeed makes a lot of sense !
The chmod +x also makes sense.

About the line-break, isn't it a git configuration issue?
You may want to configure it to keep lf on checkout ?

Here is my suggestion: create a .gitattributes file with proper rules for checkout like Dockerfile text eol=lf. I would keep the entrypoint file Dockerfile as lean as possible.
WDYT? I'm open to the discussion ofc

@ddNils
Copy link
Author

ddNils commented Nov 14, 2025

Yeah, the changes to .gitattributes make a lot more sense than doing it in the code. I didn't think about that.
I will update the pr later, or you can do that, if you want.

@digiz3d
Copy link
Owner

digiz3d commented Nov 14, 2025

Yeah, the changes to .gitattributes make a lot more sense than doing it in the code. I didn't think about that. I will update the pr later, or you can do that, if you want.

We will want to make sure it works on Windows before merging. Please feel free to do it whenever you can 👌
(don't forget to use git add --renormalize .)

@digiz3d digiz3d changed the title Add sanitation in dockerfile and block notifications fix: properly build Docker image on windows and block browser notifications Nov 14, 2025
@digiz3d digiz3d changed the title fix: properly build Docker image on windows and block browser notifications fix: properly build Docker image on Windows and block browser notifications Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants