fix: properly build Docker image on Windows and block browser notifications #119
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I am working on a Windows machine, I needed to make sure, that docker-entrypoint would not include windows-style line breaks. Unfortunately my IDE was adding them on default so I added a line in the dockerfile to remove the line-breaks and adjust the permissions on docker-entrypoint before using it.
More importantly I added
--disable-notificationsto the chrome args to prevent notifications like " wants to show notifications" - block or allow - which was obstructing my recording.great tool otherwise, really like it!