Correct angle_max to avoid fencepost error #11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
r2000_node.cppcreates scans within the range of(-π,+π)with a dynamicangle_incrementthat is defined by thesamples_per_scanvariable. Using this range leads to a fencepost error, where the scan in 0° direction is contained two times and therefore seems to be missing.Some ROS libraries (e.g. navigation_2d) complain about that error and others ignore it. Ignoring it leads to a incorrect conversion of the scan points into 2D coordinates (which is important for accurate SLAM).
Since the deviation is neglible and not necessarily visible (and thus mostly ignored), it can be further rectified by adapting the maximum range of the angle:
Thank you for considering merging this change. :)