Make Date+Extension not public #23
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because it conflicts with, for instance, [SwiftDate](https://github.com/malcommac/SwiftDate)
Author
|
Mind me asking why you included some public extensions (like Date, Locale, NSAttributedString, etc.) and not using them in your own source? I understand those extensions are useful, but in the end could up conflicting with other libraries. |
SigmundRakes
approved these changes
Apr 21, 2018
SigmundRakes
left a comment
SigmundRakes
left a comment
There was a problem hiding this comment.
Makes the Library usable with Others such as SwiftDat - I don't see why this wouldn't be seen as great
pahnev
approved these changes
May 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because it conflicts with, for instance, SwiftDate.