Skip to content

Bringing in Liberia Indicators data and updating to include Liberia in pipeline #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Apr 30, 2025

Conversation

elysenko
Copy link
Contributor

No description provided.

@elysenko elysenko added the enhancement New feature or request label Apr 20, 2025
@@ -0,0 +1,204 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That file only brings in the data to MEGA, it doesn't actually retrieve country specific data

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a new file called read_subnational_population_gdl That implements functions to read from the table and write data

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That file only brings in the data to MEGA, it doesn't actually retrieve country specific data

Is that so? What is this code doing https://github.com/dime-worldbank/mega-indicators/blob/main/population/global_data_lab_subnational_population.r#L62 Why is there Albania subnational population data in table prd_mega.indicator.global_data_lab_subnational_population?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This brings in all subnational data available in GDL. There is Albania subnational data there because it is in GDL. Note that the current code uses interpolation. Albania only has data for 2005, 2009, and 2017

ddf['population'] = ddf.population.map(lambda x: x*1_000_000)
ddf['adm1_name'] = ddf['adm1_name'].str.lower()
ddf = ddf[ddf.adm1_name!='total']
ddf['adm1_name'] = ddf['adm1_name'].str.strip().str.title()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elysenko have you verified that after this transformation the adm1_names are matching those in BOOST?

Copy link
Contributor Author

@elysenko elysenko Apr 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Boost has some rows that are blank or marked dfp which looks like an environmental tag that I can't trace to a specific region. However, the rows tied to one of the actual 15 admin1 levels in Liberia match the incoming data

@elysenko elysenko merged commit f156350 into main Apr 30, 2025
@elysenko elysenko deleted the liberia branch April 30, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants