-
Notifications
You must be signed in to change notification settings - Fork 0
Bringing in Liberia Indicators data and updating to include Liberia in pipeline #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -0,0 +1,204 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is not necessary. Use and if needed modify https://github.com/dime-worldbank/mega-indicators/blob/main/population/global_data_lab_subnational_population.r
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That file only brings in the data to MEGA, it doesn't actually retrieve country specific data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a new file called read_subnational_population_gdl That implements functions to read from the table and write data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That file only brings in the data to MEGA, it doesn't actually retrieve country specific data
Is that so? What is this code doing https://github.com/dime-worldbank/mega-indicators/blob/main/population/global_data_lab_subnational_population.r#L62 Why is there Albania subnational population data in table prd_mega.indicator.global_data_lab_subnational_population
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This brings in all subnational data available in GDL. There is Albania subnational data there because it is in GDL. Note that the current code uses interpolation. Albania only has data for 2005, 2009, and 2017
ddf['population'] = ddf.population.map(lambda x: x*1_000_000) | ||
ddf['adm1_name'] = ddf['adm1_name'].str.lower() | ||
ddf = ddf[ddf.adm1_name!='total'] | ||
ddf['adm1_name'] = ddf['adm1_name'].str.strip().str.title() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elysenko have you verified that after this transformation the adm1_names are matching those in BOOST?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Boost has some rows that are blank or marked dfp which looks like an environmental tag that I can't trace to a specific region. However, the rows tied to one of the actual 15 admin1 levels in Liberia match the incoming data
No description provided.