fix: check if webgl is enabled and call onerror otherwise#297
Open
meesfrensel wants to merge 1 commit into
Open
fix: check if webgl is enabled and call onerror otherwise#297meesfrensel wants to merge 1 commit into
meesfrensel wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 93a3ae0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@meesfrensel is attempting to deploy a commit to the Daniel Imfeld's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #279 by checking for WebGL support before trying to create the map.
As reported in the bug, the svelte app can completely freeze when webgl is disabled, and a MapLibre component is created without a
<svelte:boundary>to contain errors. It's better to just check it ourselves, and report errors to the consumer via theonerrorcallback.isWebglSupportedis basically a copy from https://maplibre.org/maplibre-gl-js/docs/examples/check-if-webgl-is-supported/