Expose stop_at_penetration parameter and hide time-of-impact details behind an Option
#419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aceeri
changed the title
stop_at_penetration parameter and hide toi details behind an Optionstop_at_penetration parameter and hide time-of-impact details behind an Option
an `Option` to prevent misusage.
Aceeri
force-pushed
the
cast-shape-penetration
branch
from
9c0eb23
to
8d52603
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently these values can be
undefinedwhich might cause some weird bugs for users, so ideally I think it is hidden if we reasonably know the results won't be useful. I also don't think that the documentation saying the witnesses/normals are local space. At least the witness points seem to be world-space in the times I've used this method. Will need to dive a bit deeper into that though.