Update to Bevy 0.12 #439
Merged
Update to Bevy 0.12 #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tim-blackbird
commented
Nov 1, 2023
Comment on lines
-91
to
+94
| systems::init_async_scene_colliders.after(bevy::scene::scene_spawner_system), | ||
| systems::init_async_scene_colliders, |
There was a problem hiding this comment.
scene_spawner_system runs in a schedule before PostUpdate
tim-blackbird
commented
Nov 1, 2023
Comment on lines
+1638
to
+1639
| app.add_plugins(HeadlessRenderPlugin) | ||
| .add_systems(PostUpdate, init_async_scene_colliders); |
There was a problem hiding this comment.
Old test was failing because the scene_spawner_system was moved to its own schedule that runs in between Update and PostUpdate.
Updated to match the way init_async_scene_colliders is added by the actual plugin.
10 tasks
|
Bevy 0.12 is officially out |
tim-blackbird
force-pushed
the
bevy-0.12
branch
from
daee384
to
8c033f1
Compare
mnmaita
reviewed
Nov 5, 2023
czaloj
reviewed
Nov 5, 2023
tim-blackbird
force-pushed
the
bevy-0.12
branch
from
8c033f1
to
e8ee5b0
Compare
tim-blackbird
force-pushed
the
bevy-0.12
branch
from
e8ee5b0
to
aa4aa2c
Compare
|
Should this update the bevy_rapier version to 0.23 ? |
The version should be bumped before this change is released, but I'll leave that up to @sebcrozet. |
Aceeri
approved these changes
Nov 8, 2023
|
Thanks @devil-ira and @Aceeri for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just waiting on the Bevy 0.12 release to move out of draft mode :)