Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rapier 0.20 feature:
RevoluteJoint::angle
+ more detailed joints enum #530rapier 0.20 feature:
RevoluteJoint::angle
+ more detailed joints enum #530Changes from 11 commits
a49031a
e92ece0
4085212
ae822d7
227c23c
f4d1f32
e3ef235
cce0ce3
3c642d0
b4016ab
5b7363f
e537660
d0299c5
7f173ea
2a1e5d1
dd7ede2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These could be
AsRef
/AsMut
implementations instead.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
true, I'll do that.
For the story behind this explicit naming: ideally I would have liked to wrap our joints (
bevy_rapier::FixedJoint
, etc...) around the correct joint from rapier (rapier::FixedJoint
, etc.), so a user could use the relevant functions from rapier if some functions were not exposed by bevy_rapier (it can easily be forgotten...), but I had difficulties, probably the builder had to be updated significantly so I dropped the idea.See #529 for similar reasoning logic.