Skip to content

Added functionality to only present anchor tags that have an href poi… #972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abegus wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added functionality to only present anchor tags that have an href poi… #972

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40242fb
Added functionality to only present anchor tags that have an href poi…
abegustafson Apr 4, 2017
269adb7
fixed bug
abegustafson Apr 4, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions dist/jquery.magnific-popup.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,18 @@ MagnificPopup.prototype = {
var i;

if(data.isObj === false) {

//remove items where the href is empty. EX. <a href="#" ...
for(i = 0; i < data.items.length; i++){
it = data.items[i];
if( it.href.substr(it.href.length -1 , 1) === '#'){
//remove it
data.items.splice(i,1);
//decrement i because you just removed an element from the array.
i--;
}
}

// convert jQuery collection to array to avoid conflicts later
mfp.items = data.items.toArray();

Expand Down
12 changes: 12 additions & 0 deletions src/js/core.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,18 @@ MagnificPopup.prototype = {
var i;

if(data.isObj === false) {

//remove items where the href is empty. EX. <a href="#" ...
for(i = 0; i < data.items.length; i++){
var it = data.items[i];
if( it.href.substr(it.href.length -1 , 1) === '#'){
//remove it
data.items.splice(i,1);
//decrement i because you just removed an element from the array.
i--;
}
}

// convert jQuery collection to array to avoid conflicts later
mfp.items = data.items.toArray();

Expand Down