fix: correct noise model — 4 identifiable params, drop anomalous Bell… - #7
Merged
Conversation
… row - readout collapsed to a single rate r: the previous r0/r1 pair was non-identifiable (model used only their average, optimizer returned r0==r1), so the '5-parameter' model was really 4 - N_PARAMS_EXTENDED=4 now used in the AIC/BIC penalty (was miscounted as 5) - implement fit_simple_model (2-param) so compare_models uses a real fitted SSE instead of the notebook-06 placeholder (sse_ext*1.5) - aic_bic_from_sse guards sigma2<=0 (no more -inf) - self-test uses the three verified Bell fidelities (0.859/0.940/0.944); the anomalous d5sd9mv (0.9630) row is excluded, matching the CSV/docs - self-test correctly prefers the simple model for 3 points - analysis/README.md updated to match Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N5MUSLxPMgCHtck8iMkCvD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… row
Claude-Session: https://claude.ai/code/session_01N5MUSLxPMgCHtck8iMkCvD
Pull request
Summary
Describe the purpose of this pull request.
Changes
Validation
bash scripts/smoke_test.shbash scripts/verify_checksums.shAdditional context
Add screenshots, logs, or related issue links if helpful.