feat: properly handle +CGCONTRDP when ipv6 is enabled#59
Merged
diondokter merged 1 commit intodiondokter:masterfrom Mar 24, 2026
Merged
feat: properly handle +CGCONTRDP when ipv6 is enabled#59diondokter merged 1 commit intodiondokter:masterfrom
diondokter merged 1 commit intodiondokter:masterfrom
Conversation
nponsard
force-pushed
the
fix/ipv6-parsing
branch
2 times, most recently
from
2531801 to
5e25e5b
Compare
nponsard
changed the title
diondokter
approved these changes
Mar 20, 2026
Owner
diondokter
left a comment
diondokter
left a comment
There was a problem hiding this comment.
Cool, thanks for coming back to fix it!
Contributor
Author
|
I'm testing a bit more before marking it as ready. |
nponsard
force-pushed
the
fix/ipv6-parsing
branch
2 times, most recently
from
879f2a0 to
96cfab4
Compare
Signed-off-by: Nils Ponsard <nils.ponsard@inria.fr>
nponsard
force-pushed
the
fix/ipv6-parsing
branch
from
96cfab4 to
387b9c8
Compare
Contributor
Author
|
Should be good now, tested on an nrf9160dk with the |
Owner
|
Thanks! |
Contributor
Author
|
Thanks for the release ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I didn't read the spec correctly, turns out
+CGCONTRDPreturns two messages when it gets configured in dual stack mode. On the SIM I tested this happens when IPV6 or IPV4V6 PDN type is used.I have to split the lines because
at_commands::parser::CommandParsercannot handle that many fields.This is breaking, it changes the struct returned on status change.