feat(embassy-net): ability to turn off the modem#60
Merged
diondokter merged 2 commits intodiondokter:masterfrom Mar 24, 2026
Merged
feat(embassy-net): ability to turn off the modem#60diondokter merged 2 commits intodiondokter:masterfrom
diondokter merged 2 commits intodiondokter:masterfrom
Conversation
nponsard
force-pushed
the
fix/disable
branch
2 times, most recently
from
5393d6d to
bfec440
Compare
The previous logic kept the socket running when `context::Control::disable()` was called, keeping one link active and preventing the automatic deactivation of the LTE-M modem. Signed-off-by: Nils Ponsard <nils.ponsard@inria.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous logic kept the socket running when
context::Control::disable()was called, keeping one link active and preventing the automatic deactivation of the LTE-M modem.