Skip to content

Fix bugs in schema wipe SQL and CLI command#1307

Merged
Wizard1209 merged 6 commits into
nextfrom
fix/schema-wipe
Apr 8, 2026
Merged

Fix bugs in schema wipe SQL and CLI command#1307
Wizard1209 merged 6 commits into
nextfrom
fix/schema-wipe

Conversation

@droserasprout
Copy link
Copy Markdown
Collaborator

@droserasprout droserasprout commented Jan 8, 2026

Fixes #1280
Fixes #1281

@droserasprout droserasprout added this to the 8.5.2 milestone Jan 8, 2026
@droserasprout droserasprout added bug Something isn't working documentation Improvements or additions to documentation labels Jan 8, 2026
@droserasprout droserasprout marked this pull request as draft January 9, 2026 19:53
@droserasprout droserasprout removed the documentation Improvements or additions to documentation label Jan 12, 2026
@droserasprout droserasprout marked this pull request as ready for review March 28, 2026 00:39
Copy link
Copy Markdown
Member

@Wizard1209 Wizard1209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Clean rewrite of dipdup_wipe — proper format(), no more silent exception swallowing, correct handling of extension-owned objects. Crash fixes for empty/in-memory DBs are straightforward.

@Wizard1209 Wizard1209 merged commit 8c7efe2 into next Apr 8, 2026
4 of 5 checks passed
@Wizard1209 Wizard1209 deleted the fix/schema-wipe branch April 8, 2026 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dipdup_wipe function doesn't affect Timescale hypertables schema wipe command crashes on empty db

2 participants