Added support for MySQL/ MariaDB #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added support for MySQL and MariaDB. There are a few code duplications between MySQL and MariaDB (specially in queries). If something like "gorm" is used, then there will be no duplicated queries. If you allow Gorm, then let me know.
I've found a bug where scheduling is not working expected for corn entries. If I schedule at "18:20:55" to execute the job every minute it executes at "18:21:00", so It executes after 5 seconds for first time. This can be a big issue for some scenarios.
I think adding (gob serialized) "[]byte" as event payload will make the events powerful. If you accept this then also let me know.
Thanks