Raise a ValidationError for incorrect related slug when importing resources#631
Open
AdrianDAlessandro wants to merge 3 commits intomainfrom
Open
Raise a ValidationError for incorrect related slug when importing resources#631AdrianDAlessandro wants to merge 3 commits intomainfrom
AdrianDAlessandro wants to merge 3 commits intomainfrom
Conversation
d36dc6a to
03095e6
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR prevents incorrect slugs from being ignored when importing to the DB using the Resource classes in
io_resources.pyIt achieves this by adding a check to the
cleanmethod of the ForeignKey and M2M Widget classes. If any of the slugs provided in the import data do not exist, it raises a ValidationError. This error provides a dictionary with the offending field as keys, which renders nicely in the Admin backend.M2M Example with the following import data
ForeignKey Example with the following import data
Fixes #630
Type of change
Key checklist
python -m pytest)mkdocs serve)pre-commit run --all-files)Further checks