Fix conservative overcurrent mode never reducing charger limit#92
Open
attaxia wants to merge 3 commits into
Open
Fix conservative overcurrent mode never reducing charger limit#92attaxia wants to merge 3 commits into
attaxia wants to merge 3 commits into
Conversation
Minor edit - updated the maintained icon for 2026 as there have been commits.
Conservative mode clamped phase_limit at 0 (max(0, phase_limit + avail)), returning a positive value that PowerAllocator read as surplus, so cuts never fired and the charger was never throttled during overcurrent. Emit the real negative deficit immediately instead, matching the relative-availability contract used by the optimised/default balancers. Conservative stays distinct from optimised by cutting right away rather than waiting for cumulative trip risk to cross the threshold. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Conservative mode clamped phase_limit at 0 (max(0, phase_limit + avail)), returning a positive value that PowerAllocator read as surplus, so cuts never fired. Emit the real negative deficit immediately instead, matching the relative-availability contract used by optimised/default balancers.