Added LDAP signing + Channel Binding compatibility to dnstool.py - #41
Open
flashlam wants to merge 1 commit into
Open
Added LDAP signing + Channel Binding compatibility to dnstool.py#41flashlam wants to merge 1 commit into
flashlam wants to merge 1 commit into
Conversation
numoworld
approved these changes
Oct 23, 2024
|
Is it possible to get this merged with the main branch? Its a very neat PR. |
|
Thanks for this PR! I was having issues with an IPS (Frocepoint) (mis-) detection the addition of DNS records as an attempt to exploit CVE-2020-0664. Attempts to switch LDAPS failed on me with: because the DC was requiring channel binding. Using this PR fixed the issue for me. |
|
this should be merged yes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Dirk-jan !
A tiny PR to add LDAP signing and Channel Binding compatibility using the package ldap3-bleeding-edge which includes those features.
Do not hesitate if you have any remarks