Fix relay session check and NoneType crash in do_relay() - #70
Open
dfirdeferred wants to merge 1 commit into
Open
Fix relay session check and NoneType crash in do_relay()#70dfirdeferred wants to merge 1 commit into
dfirdeferred wants to merge 1 commit into
Conversation
- Fix initConnection() return value bug in do_relay(): initConnection() returns None (no explicit return), causing `if not None` to always evaluate True and abort the relay even after a successful bind. Now checks client.session.bound instead. - Fix NoneType crash in httprelayserver do_relay(): parsed_target.hostname can be None, causing AttributeError on .lower(). Added None guard. - Add LOG.debug statements to ldap_kerberos_auth() for SASL GSSAPI bind tracing (visible with -debug flag). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
initConnection() return value bug:
do_relay()in bothsmbrelayserver.pyandhttprelayserver.pychecksif not client.initConnection(...). SinceinitConnection()has no explicit return statement, it returns
None, andnot Noneevaluates to
True—silently aborting every relay after a successful bind. Fixed by checking
client.session.boundinstead.NoneType crash in httprelayserver:
parsed_target.hostnamecan beNone, causingAttributeErroron.lower()during SPN hostname comparison. Added aNone guard.
Debug logging: Added
LOG.debugstatements toldap_kerberos_auth()for SASL GSSAPIbind tracing (only visible with
-debugflag).Files changed
lib/servers/smbrelayserver.py— initConnection fixlib/servers/httprelayserver.py— initConnection fix + NoneType guardlib/utils/kerberos.py— debug logging